Skip to content

fix(ci): wait for batch tree nodes in integration test#128

Merged
ryan-wong-coder merged 1 commit into
mainfrom
fix/batch-tree-ci-node-wait
May 6, 2026
Merged

fix(ci): wait for batch tree nodes in integration test#128
ryan-wong-coder merged 1 commit into
mainfrom
fix/batch-tree-ci-node-wait

Conversation

@ryan-wong-coder

Copy link
Copy Markdown
Collaborator

Summary

  • Fixes the batch integration test race where leaves could become visible before internal batch tree nodes in the local proofstore.
  • Writes local batch tree nodes before leaves so a visible leaf is a better readiness signal for the tree projection.
  • Polls for the expected batch tree node directly in TestServiceCommitsFullBatch.

Test plan

  • go test -count=1 -mod=readonly -tags=integration ./internal/batch -run TestServiceCommitsFullBatch -v
  • go test -count=1 -mod=readonly ./internal/batch ./internal/proofstore/...
  • go test -count=1 -mod=readonly -tags=integration ./internal/batch
  • go test -count=1 -mod=readonly -tags=integration ./...

Closes #127

Made with Cursor

Close the local proofstore visibility window by writing batch tree nodes before leaves and polling for nodes directly in the batch integration assertion. Closes #127.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ryan-wong-coder
ryan-wong-coder merged commit 723c856 into main May 6, 2026
9 checks passed
@ryan-wong-coder
ryan-wong-coder deleted the fix/batch-tree-ci-node-wait branch May 6, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flaky batch tree node integration test

2 participants