Expose add_to_blog, new_role, and blog_id fields in signup list and get - #630
Open
swissspidy wants to merge 2 commits into
Open
Expose add_to_blog, new_role, and blog_id fields in signup list and get#630swissspidy wants to merge 2 commits into
swissspidy wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthrough
ChangesSignup metadata exposure
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI as WP-CLI
participant Signup_Command
participant MultisiteSignups
CLI->>Signup_Command: list with signup filters
Signup_Command->>MultisiteSignups: fetch signup records
MultisiteSignups-->>Signup_Command: signup data and serialized metadata
Signup_Command-->>CLI: filtered and paginated fields
CLI->>Signup_Command: get signup
Signup_Command->>MultisiteSignups: fetch selected signup
MultisiteSignups-->>Signup_Command: normalized signup fields
Signup_Command-->>CLI: add_to_blog, new_role, and blog_id
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
add_to_blog,new_role, andblog_idas available fields forwp user signup listandwp user signup get, and enables filtering by them.add_to_blogandnew_roleare accessible as fields.add_to_blogandblog_idto allow querying and filtering by either name.Signup_Command::list_()to support filtering by--new_role,--blog_id, and--add_to_blog.Closes #629
Summary by CodeRabbit
add_to_blog,new_role, andblog_id.blog_id,add_to_blog, andnew_role, plus corresponding retrieval viaget.