Skip to content

Conversation

@colinmurphy
Copy link
Member

Added nonce for the download link on the view log page.

Description

Added missing security nonce for the view log page when downloading the CSV file.

Related Issue

Fixes #481.

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

Added nonce for the download link on the view log page.
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2025

🦋 Changeset detected

Latest commit: 3741a12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wpgraphql-logging-wordpress-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

📦 Plugin Artifacts Ready!

Download from GitHub Actions run

Available plugins:

  • ✅ wpgraphql-logging.zip

See the "Artifacts" section at the bottom of the Actions run page

Added nonce for the detail page for the download link.
@colinmurphy colinmurphy marked this pull request as ready for review November 11, 2025 18:59
@colinmurphy colinmurphy requested a review from a team as a code owner November 11, 2025 18:59
@colinmurphy colinmurphy added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit a720730 Nov 12, 2025
21 checks passed
@colinmurphy colinmurphy deleted the bug-fix-logging-nonce-issue branch November 12, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(logging): File download doesn't work on details page

3 participants