Add warning about meters and band-aid over the unit issue.#180
Merged
AustinShalit merged 4 commits intowpilibsuite:masterfrom Jan 30, 2020
carbotaniuman:master
Merged
Add warning about meters and band-aid over the unit issue.#180AustinShalit merged 4 commits intowpilibsuite:masterfrom carbotaniuman:master
AustinShalit merged 4 commits intowpilibsuite:masterfrom
carbotaniuman:master
Conversation
Contributor
|
Why change to specific versions? |
Contributor
Author
|
I did not mean that. Looks like a debugging artifact, will revert tommorow morning. |
AustinShalit
requested changes
Jan 29, 2020
Apply suggestions from Austin Co-Authored-By: Austin Shalit <austinshalit@gmail.com>
gftabor
approved these changes
Jan 30, 2020
Contributor
gftabor
left a comment
gftabor
left a comment
There was a problem hiding this comment.
The exported units are not separated from the chosen internal units to better support working with WPIlib trajectory generators. Updating to new system is seemless.
Contributor
|
@AustinShalit when you are satisfied with changes feel free to merge. |
AustinShalit
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.