when a new path is clicked on the first waypoint is selected#218
Merged
AustinShalit merged 4 commits intowpilibsuite:mainfrom Mar 26, 2021
Merged
when a new path is clicked on the first waypoint is selected#218AustinShalit merged 4 commits intowpilibsuite:mainfrom
AustinShalit merged 4 commits intowpilibsuite:mainfrom
Conversation
Contributor
|
LGTM |
Member
|
@jasondaming Can you look at ways we can make it so quickly switching between paths without making edits will not cause the "do you want to save" dialog to show up? |
Member
Author
|
okay would that be in this PR or separate? |
Member
|
I think in this PR because I do not see the behavior on the main branch. |
Member
Author
|
Normally when you click on a path it doesn't actually activate any of the waypoints. To recreate click on a path then on a waypoint in that path then click on different path. The problem here is that any time a path is "selected" it is added to the list of paths to be checked for modifications. |
AustinShalit
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #214
Closes #196