Skip to content

Reverse now just reverses the waypoints in the path making it go back…#227

Merged
AustinShalit merged 6 commits intowpilibsuite:mainfrom
jasondaming:noreverse
Apr 16, 2021
Merged

Reverse now just reverses the waypoints in the path making it go back…#227
AustinShalit merged 6 commits intowpilibsuite:mainfrom
jasondaming:noreverse

Conversation

@jasondaming
Copy link
Copy Markdown
Member

…wards

Closes #215

@AustinShalit
Copy link
Copy Markdown
Member

Is this ok to merge in the middle of the season?

@jasondaming
Copy link
Copy Markdown
Member Author

I think it is strictly better, it is just more intuitive IMO. I would say there are a lot of changes that I want to make before the next "release". So I would think we should merge each of these as we go. Is there even a way that teams can get these new updates without explicitly grabbing them?

@jasondaming jasondaming requested a review from AustinShalit April 3, 2021 13:33
@jasondaming jasondaming added the Ready for Review Author believes this PR to be done. label Apr 3, 2021
@AustinShalit AustinShalit requested a review from prateekma April 16, 2021 01:58
@AustinShalit AustinShalit merged commit c7aecb6 into wpilibsuite:main Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Review Author believes this PR to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reverse Spline shouldn't horizontally flip the waypoints.

3 participants