Add callback for mDNS service resolver #7986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also fixed a bug where the byte order was wrong. |
PeterJohnson
requested changes
May 22, 2025
Member
PeterJohnson
left a comment
PeterJohnson
left a comment
There was a problem hiding this comment.
I don't love the names, but I don't have a better suggestion.
| * not send the data to the event queue. | ||
| */ | ||
| bool SetCopyCallback(std::function<bool(const ServiceData&)> callback); | ||
| /** |
Member
There was a problem hiding this comment.
Should have a newline before each of these comment blocks.
Member
Author
There was a problem hiding this comment.
For some reason this is what the formatter did. Not sure why.
Member
There was a problem hiding this comment.
The #ifdef __cplusplus around around the whole file is confusing wpiformat's #include parser. It expects #ifdefs to stop before the non-include part of the code starts, since it has to rely on that to sort groups of #ifdef'd #includes properly.
PeterJohnson
approved these changes
May 23, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the only way to read items is to use the event. And in my use case, adding that would require adding my own thread just for handling that event.