Coalesce broken with all floats - #970
Merged
Merged
Conversation
1 task
thomasstvr
previously approved these changes
May 15, 2026
Contributor
Author
|
@thomasstvr can you reapprove pls? |
thomasstvr
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new test case to ensure that coalescing columns with float values preserves both the values and their data type, and also updates the implementation to use
.to_numpy(dtype=object)for improved consistency when handling data types.Testing improvements:
test_all_floats) to verify that coalescing two columns of all floats preserves both the float values and their data type in the output column.Implementation updates:
merge.pyto use.to_numpy(dtype=object)instead of.valueswhen converting columns to a NumPy array, ensuring more explicit handling of data types.