Skip to content

updates to MYNN-EDMF and related modules#2267

Merged
weiwangncar merged 3 commits into
wrf-model:developfrom
joeolson42:mynnedmf_20260204
Jan 30, 2026
Merged

updates to MYNN-EDMF and related modules#2267
weiwangncar merged 3 commits into
wrf-model:developfrom
joeolson42:mynnedmf_20260204

Conversation

@joeolson42
Copy link
Copy Markdown
Contributor

@joeolson42 joeolson42 commented Jan 4, 2026

The purpose of this PR is to update the MYNN-EDMF code in WRF to be consistent with the updated NOAA Tech Note. This same version of the MYNN-EDMF submodule will be implemented into MPAS (next), then CCPP.

TYPE: enhancement/new features

KEYWORDS: MYNN-EDMF, turbulence, clouds, downdrafts, closure levels

SOURCE: Joseph Olson (NOAA-GSL)

DESCRIPTION OF CHANGES:
Problem(s):

  1. Excessive low-level clouds, especially over water
  2. prototype version of downdrafts was not well tested,
  3. excessive near-surface mixing in very stable conditions.
  4. Checks in module_check_a_mundo.F needed updates associated with the incoming changes. Also there was a redundant check that needed to be removed.

Solution(s):

  1. revised subgrid clouds option (bl_mynn_cloudpdf = 2) improved upon the excessive low-level clouds previously noted.
  2. More testing of the downdrafts has been performed and several changes were made to improve the scale-awareness as well as the underlying physical representation of downdrafts. Still requires more testing with significantly different vertical resolution. Not active by default but considered more reliable.
  3. A handful of related revisions/tunings was made to improve low level jet structures in stable conditions. This touched the LBC for TKE , Prandtl number regulation, and a mixing length revision. All have been documented in the updated tech note (doi:10.25923/rahr-sj70).
  4. module_check_a_mundo.F has been modified to work with the updated MYNN-EDMF options.

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status develop to get formatted list)
M Registry/Registry.EM_COMMON
M dyn_em/module_first_rk_step_part1.F
M phys/MYNN-EDMF
M phys/module_pbl_driver.F
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. WFIP3 case studies (using WRF) show robust improvement in stable LLJ conditions. Realtime testing (mostly in MPAS) show improvements relative to HRRR. Some of this was previewed in the last WRF/MPAS workshop but more modifications have been made since.
  2. The Jenkins tests are all passing.

RELEASE NOTE: The MYNN-EDMF submodule has been updated to be consistent with the updated NOAA Tech Note. This same version of the MYNN-EDMF submodule will be implemented into MPAS (next), then CCPP. Some recent updates include (1) revised subgrid clouds option (bl_mynn_cloudpdf = 2) improves the low-level clouds. (2) more testing of the downdrafts has been performed and several changes were made to improve the scale-awareness as well as the underlying physical representation of downdrafts. (3) a handful of related revisions/tunings was made to improve low level jet structures in stable conditions for several WFIP3 cases. All have been documented in the updated tech note (doi:10.25923/rahr-sj70). Beware of the new MYNN-EDMF-specific options (bl_mynn_mixaerosols, bl_mynn_mixnumcon, and bl_mynn_mixscalars). Their defaults may not be suitable for your research/applications, but in general, we suggest to use this options and set scalar_pblmix=0 and tracer_pblmix=0, since the MYNN can perform the associated nonlocal mixing.

@joeolson42 joeolson42 requested review from a team as code owners January 4, 2026 16:15
@weiwangncar
Copy link
Copy Markdown
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@joeolson42
Copy link
Copy Markdown
Contributor Author

Latest results after the recent update to the submodule pointer:

Test Type | Expected | Received | Failed
= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Number of Tests : 23 24
Number of Builds : 60 57
Number of Simulations : 158 150 0
Number of Comparisons : 95 86 0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None 

Comment thread Registry/Registry.EM_COMMON
dudhia
dudhia previously approved these changes Jan 27, 2026
@joeolson42
Copy link
Copy Markdown
Contributor Author

I just pushed an update to the pointer to the MYNN-EDMF, no internal WRF files were touched. This modification only removes the upper bounds applied to WFA and IFA after mixing, such that they should no longer impact any simulation.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Jan 27, 2026

I will re-do the approval after the tests pass.

@joeolson42
Copy link
Copy Markdown
Contributor Author

test results after the latest change:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@weiwangncar weiwangncar merged commit 88a2d5d into wrf-model:develop Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants