updates to MYNN-EDMF and related modules#2267
Merged
Merged
Conversation
Collaborator
|
The regression test results: |
Contributor
Author
|
Latest results after the recent update to the submodule pointer: Test Type | Expected | Received | Failed |
dudhia
reviewed
Jan 27, 2026
dudhia
previously approved these changes
Jan 27, 2026
Contributor
Author
|
I just pushed an update to the pointer to the MYNN-EDMF, no internal WRF files were touched. This modification only removes the upper bounds applied to WFA and IFA after mixing, such that they should no longer impact any simulation. |
Collaborator
|
I will re-do the approval after the tests pass. |
Contributor
Author
|
test results after the latest change: |
weiwangncar
approved these changes
Jan 28, 2026
dudhia
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to update the MYNN-EDMF code in WRF to be consistent with the updated NOAA Tech Note. This same version of the MYNN-EDMF submodule will be implemented into MPAS (next), then CCPP.
TYPE: enhancement/new features
KEYWORDS: MYNN-EDMF, turbulence, clouds, downdrafts, closure levels
SOURCE: Joseph Olson (NOAA-GSL)
DESCRIPTION OF CHANGES:
Problem(s):
Solution(s):
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status developto get formatted list)M Registry/Registry.EM_COMMON
M dyn_em/module_first_rk_step_part1.F
M phys/MYNN-EDMF
M phys/module_pbl_driver.F
M share/module_check_a_mundo.F
TESTS CONDUCTED:
RELEASE NOTE: The MYNN-EDMF submodule has been updated to be consistent with the updated NOAA Tech Note. This same version of the MYNN-EDMF submodule will be implemented into MPAS (next), then CCPP. Some recent updates include (1) revised subgrid clouds option (bl_mynn_cloudpdf = 2) improves the low-level clouds. (2) more testing of the downdrafts has been performed and several changes were made to improve the scale-awareness as well as the underlying physical representation of downdrafts. (3) a handful of related revisions/tunings was made to improve low level jet structures in stable conditions for several WFIP3 cases. All have been documented in the updated tech note (doi:10.25923/rahr-sj70). Beware of the new MYNN-EDMF-specific options (bl_mynn_mixaerosols, bl_mynn_mixnumcon, and bl_mynn_mixscalars). Their defaults may not be suitable for your research/applications, but in general, we suggest to use this options and set scalar_pblmix=0 and tracer_pblmix=0, since the MYNN can perform the associated nonlocal mixing.