Skip to content

bug fix for TEMPO and aer_opt=3 combination#2302

Merged
islas merged 1 commit into
wrf-model:developfrom
joeolson42:tempo_aeropt_fix
Mar 20, 2026
Merged

bug fix for TEMPO and aer_opt=3 combination#2302
islas merged 1 commit into
wrf-model:developfrom
joeolson42:tempo_aeropt_fix

Conversation

@joeolson42
Copy link
Copy Markdown
Contributor

This PR fixes a crash when TEMPO is run in combination with aer_opt=3

TYPE: bug fix

KEYWORDS: TEMPO, aer_opt=3

SOURCE: Joseph Olson (NOAA-GSL)

DESCRIPTION OF CHANGES:
Problem:
Model crashes because two arrays are left unallocated

Solution:

  1. Include taod5503d and taod5502d in the tempo_aerosolaware package
  2. Add a safety check in module_check_a_mundo.F to guard against misconfigurations

LIST OF MODIFIED FILES: list of changed files (use git diff --name-status develop to get formatted list)
M Registry/Registry.EM_COMMON
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. Do mods fix problem? Yes. Testing in single case study.
  2. Are the Jenkins tests all passing?

@joeolson42 joeolson42 requested review from a team as code owners March 17, 2026 16:32
@joeolson42
Copy link
Copy Markdown
Contributor Author

Test Type | Expected | Received | Failed
= = = = = = = = = = = = = = = = = = = = = = = = = = = =
Number of Tests : 23 24
Number of Builds : 60 57
Number of Simulations : 158 150 0
Number of Comparisons : 95 86 0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@islas islas merged commit 96b7ca4 into wrf-model:develop Mar 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants