fix(opy): converge source failure frontiers - #168
Merged
Conversation
Reach the pinned semantic frontiers for source constants, annotations, settings, comprehensions, and receiver members. Fixes #167
Teakowa
requested changes
Sep 2, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
Please address the inline finding.
| )); | ||
| } | ||
| cst::SettingsNode::String { | ||
| name: String::new(), |
Contributor
There was a problem hiding this comment.
Major — This fallback classifies an unquoted OPY settings expression as SettingsNode::String. That is not just an opaque carrier: the compiler maps HIR String directly to workshop_rs::settings::SettingsNode::String, so a valid expression-valued setting that reaches backend lowering is emitted as a literal string instead of preserving/evaluating the expression. workshop-rs already distinguishes raw settings specifically to avoid fabricating a type. Preserve this as an explicit non-literal/unsupported expression (and fail lowering if necessary) rather than representing it as String.
Keep unquoted settings expressions distinct from string literals through the HIR and workshop-rs conversion. Fixes #167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo fmt --all -- --checkcargo clippy --locked --workspace --all-targets --all-features -- -D warningscargo test --locked --workspace --all-targets --all-featuresFixes #167