Skip to content

refactor: organize Workshop internals by domain - #151

Merged
Teakowa merged 2 commits into
mainfrom
codex/issue-149
Sep 6, 2026
Merged

refactor: organize Workshop internals by domain#151
Teakowa merged 2 commits into
mainfrom
codex/issue-149

Conversation

@e54-bot

@e54-bot e54-bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • organize source around discoverable Workshop domains: actions, events, rules, values, settings, gameplay, and catalog
  • isolate shared frontend, analysis, output, core, and evidence implementation trees
  • split WIR domain models and preserve legacy public module paths with re-exports
  • document the source layout and ownership boundaries

Verification

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace --all-targets
  • cargo run -p workshop-rs --bin workshop-catalog-gen -- check
  • cargo doc --workspace --no-deps

Fixes #149

Move implementation into domain and shared-boundary trees while preserving legacy public module paths.

Fixes #149

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker — frontend/parser.rs and output/emitter.rs: #149 requires domain/feature-first organization and explicitly allows shared parser/emitter state only as cross-domain orchestration/context, not as the semantic home of all features. This PR mostly moves the existing parser and emitter wholesale into phase-wide frontend//output/, while actions.rs, events.rs, rules.rs, and values.rs are thin re-export facades. Contributors still have to search the phase-wide parser/emitter to understand action/event/value behavior, so the central acceptance criterion is not met. Move feature-owned parsing/emission/related behavior under the relevant domain modules and leave only genuinely cross-domain orchestration/context in the shared boundaries.

Move feature-owned parser and emitter methods beside their Workshop domains while retaining shared orchestration and legacy public paths.

Fixes #149

@Teakowa Teakowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Teakowa
Teakowa merged commit 38c0f1c into main Sep 6, 2026
4 checks passed
@Teakowa
Teakowa deleted the codex/issue-149 branch September 6, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize workshop-rs internals around discoverable Workshop domains

2 participants