refactor!: move verification support out of semantic crate - #155
Conversation
Teakowa
left a comment
There was a problem hiding this comment.
crates/workshop-rs/src/lib.rs: this removes the released public modules census, conformance, live_capture, and real_projects. v0.1.20 exposed these paths, and ADR-0002 treated workshop_rs::conformance as a canonical public contract; meanwhile release-plz.toml has semver_check = false. This can turn #152 into an unversioned breaking library API change. Preserve compatibility for the released paths, or explicitly authorize/version the breaking contract before merging.
Superseded by a clarified review: the project decision is to keep the #152 ownership/layout change and version it as an intentional breaking API change, rather than leaving the choice to the implementation agent.
Teakowa
left a comment
There was a problem hiding this comment.
crates/workshop-rs/src/lib.rs: keep the #152 ownership/layout change and remove the released workshop_rs::{census, conformance, live_capture, real_projects} paths, but treat this as an intentional breaking library API change. The current release line is 0.1.20 and release-plz.toml has semver_check = false, so this must not ship as an ordinary refactor/patch release. Update the release/versioning contract for this change to the 0.2.0 line.
Teakowa
left a comment
There was a problem hiding this comment.
The previous API-versioning finding is not fully fixed. Do not bump the workspace/package versions to 0.2.0 in this feature PR: the repository runs release-plz release on every push to main, so merging an already-unpublished 0.2.0 would publish/tag it immediately and bypass the normal release-PR review gate. Revert the manual Cargo.toml/Cargo.lock version bump and mark the change that lands on main as a Conventional Commit breaking change (refactor!: / BREAKING CHANGE:) so release-plz release-pr proposes the 0.2.0 line; the actual version bump should remain in the generated release PR.
Keep the feature branch at the current published version so merging it does not bypass the release-plz Release PR gate. BREAKING CHANGE: removing the released workshop_rs verification modules requires the next release line to be 0.2.0.
Fixes #152
Summary
workshop-rs-clitoolingevidencemodule and update architecture documentationRelease
This intentionally removes released
workshop_rs::{census, conformance, live_capture, real_projects}paths as a breaking library API change. The branch keeps workspace and package versions at0.1.20so merging the feature PR does not bypass the release-plz Release PR gate. Itsrefactor!:commit andBREAKING CHANGE:footer make release-plz propose the next0.2.0Release PR.Verification
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace --all-targetscargo run -p workshop-rs --bin workshop-catalog-gen -- check