Skip to content

fix(release): preserve version across jobs - #17

Merged
Teakowa merged 1 commit into
mainfrom
agent/fix-release-version-propagation
Aug 17, 2026
Merged

fix(release): preserve version across jobs#17
Teakowa merged 1 commit into
mainfrom
agent/fix-release-version-propagation

Conversation

@Teakowa

@Teakowa Teakowa commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the release workflow regression where downstream jobs received an empty release version.

Root cause

The workflow referenced job outputs as needs.prepare.version / needs.prepare.commit. GitHub Actions job outputs must be accessed through needs.<job>.outputs.<name>. During the current v0.1.1 release this produced unversioned artifacts such as workshop-rs-cli--x86_64-unknown-linux-gnu.tar.gz and left VERSION empty in the crates.io publish job.

Changes

  • Make build/publish/release jobs depend directly on the plan job for the authoritative release version.
  • Use needs.prepare.outputs.commit for the prepared release revision.
  • Add fail-fast guards so empty versions cannot create artifacts, publish crates, or assemble a GitHub Release.
  • Preserve the existing v0.1.1 resume/idempotency behavior; this does not create or bump another release version.

Validation

  • Compared against current main; only .github/workflows/release.yml changes.
  • Current release logs prove plan.version=0.1.1 reaches prepare, while the old downstream needs.prepare.version expression evaluates empty.
  • Downloaded release artifact confirms the regression: workshop-rs-cli--x86_64-unknown-linux-gnu.tar.gz.

The crates.io verified-email failure is separate and intentionally out of scope.

@Teakowa
Teakowa marked this pull request as ready for review August 17, 2026 17:55
@Teakowa
Teakowa merged commit 9a7932b into main Aug 17, 2026
2 checks passed
@Teakowa
Teakowa deleted the agent/fix-release-version-propagation branch August 17, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant