fix(deps): consume workshop-rs 0.1.18 - #260
Merged
Merged
Conversation
Teakowa
requested changes
Sep 5, 2026
Teakowa
left a comment
Contributor
There was a problem hiding this comment.
crates/wright-analyzer/src/analysis.rs — the createHudText branches in visit_action_value_roots / visit_values_in_action match every canonical HUD-text call, not just the synthetic Debug / Print calls introduced here. Native/provider createHudText actions therefore stop traversing their other arguments, so expensive-loop-check and repeated-value analysis can miss expressions they previously analyzed. Restrict this special path to the synthetic calls (the lowering already carries the wright:Debug / wright:Print marker) and keep normal createHudText calls on full-argument traversal.
Teakowa
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Pinned real-project workflows
Using the released opy-provider v0.1.18 and the requested entry paths, all three workflows reached Wright with source provenance provider-artifact and no fallback. The remaining settings parser diagnostics are: Bastion zh-CN and en-US, expected a settings string at line 3; Overwatch-AI-PVE zh-CN, expected a settings number at line 34. These are retained as owner-side settings contract evidence rather than masked in Wright.
Fixes #259