Skip to content

fix: D32 layer-2 grounds against the union of source-derived texts - #173

Merged
fazpu merged 2 commits into
mainfrom
fix/grounding-union-membership
Jul 29, 2026
Merged

fix: D32 layer-2 grounds against the union of source-derived texts#173
fazpu merged 2 commits into
mainfrom
fix/grounding-union-membership

Conversation

@fazpu

@fazpu fazpu commented Jul 29, 2026

Copy link
Copy Markdown
Member

Urgent fix from the GLM-5.2 smoke, diagnosed by the #161 loss ledger: 371 of 411 grounding rejections were correct decontextualizations killed by wrong attribution labels — the model adds "Caroline" (verbatim in the target chunk's turn line) but tags it header/prefix, and the per-element membership check rejects it. 27 claims survived from 19 documents.

The fix: layer-2 membership checks the union of source-derived bundle texts (target chunk, header, same-section neighbours, stored prefix); the model's source_kind stays recorded as advisory provenance but cannot reject a grounded addition. Section summaries remain outside the union — the fact-injection defense is unchanged and the poison probes still bite (asserted). The prompt now states in-chunk text needs no added_context at all. E2_EXTRACTOR_VERSION07g:union-grounding-1; dated amendments in the E2/E3 design §3.3 and D32.

Review: Grok APPROVE (2 MINOR / 2 NIT; the docs-honesty MINOR fixed in the second commit — the union excludes summaries, not the prefix, which is D79's accepted second-order channel). Final review by Claude. Fast gate local; full matrix in CI.

@fazpu
fazpu enabled auto-merge (squash) July 29, 2026 13:05
@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/rememberstack/workers
  e1.py
  e2.py
Project Total  

This report was generated by python-coverage-comment-action

@fazpu
fazpu merged commit 624bd4b into main Jul 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant