Skip to content

refactor(queryspace): make clean pre-release cut - #223

Merged
fazpu merged 3 commits into
mainfrom
refactor/queryspace-clean-cutover
Aug 7, 2026
Merged

refactor(queryspace): make clean pre-release cut#223
fazpu merged 3 commits into
mainfrom
refactor/queryspace-clean-cutover

Conversation

@fazpu

@fazpu fazpu commented Aug 6, 2026

Copy link
Copy Markdown
Member

Summary

Makes the open-query work a clean pre-release cut instead of preserving an unused compatibility surface.

  • Publishes exactly three assured operations: resolve_entity, question_context, and current_context.
  • Demotes the 17 older query patterns to examples.* saved-query examples and removes compatibility telemetry/non-inferiority machinery.
  • Routes retained operation membership and invariant checks through the accepted memory_v1 authorities.
  • Verifies the complete 24-view runtime interface shape before live SQL/saved-query execution and PostgreSQL-backed Cypher confirmation.
  • Keeps the executor-side Lance bridge coordinate-bound and fails closed on ambiguous or stale live membership.
  • Updates D83, the accepted design, analysis, implementation notes, tests, and public API/CLI/MCP documentation.
  • Keeps RLS out of the design and avoids new abstraction layers.

Important decisions

  • No deprecation window or backward-compatibility adapter: the library has no users, so now is the clean-cutover point.
  • Exact semantic view-definition equivalence remains a deploy/CI scratch-database gate; per-request runtime checks cover the live 24-view interface shape.
  • Existing registry and transport machinery remains for the three assured operations; no replacement framework was introduced.
  • Historical Batch F notes remain historical and are explicitly marked superseded.

Sources inspected

  • decisions.md (D41, D48, D54, D68, D83)
  • plan/designs/open_query_space_design.md
  • plan/implementation_notes/open_query_space_batch_{a,b,c,d,e,f}.md
  • src/rememberstack/spine/query_space/memory_v1_manifest.json
  • Query-space migrations p9_01_0022 through p9_04_0025
  • Public API, CLI, MCP, mounts, concepts, and project-status documentation

Verification

Local, deliberately focused:

  • uv run pytest -q src/tests/surfaces/test_assured_operation_authorities.py src/tests/core/test_consumption_skill.py src/tests/spine/test_query_space_manifest.py src/tests/benchmarks/test_locomo_protocol.py — 54 passed
  • uv run pytest -q src/tests/surfaces/test_query_sandbox_batch_d.py -k native_read_only_repeatable — 2 passed
  • uv run ruff check src/ benchmarks/
  • uv run ruff format --check src/ benchmarks/
  • uv run pyright src/ benchmarks/ — 0 errors
  • git diff --check
  • Independent Codex and Grok final reviews: both approved. Concrete findings fixed include raw-table authority drift, cross-kind UUID ambiguity, fact-kind withdrawal binding, same-name catalog replacement, runtime schema-check lifetime, one-snapshot enrichment, and Psycopg transaction ordering.

Limitations and follow-up

  • Database-backed integration coverage and the broad suite are delegated to Nightly CI run 31128251952.
  • The paid LoCoMo benchmark was not run and must not be started automatically.
  • No premature compatibility/deprecation follow-up remains; future additions should extend the accepted open-query contract directly.

Contributor agreement

Signing on behalf of a legal entity (leave blank if accepting individually):

@fazpu fazpu closed this Aug 6, 2026
@fazpu fazpu reopened this Aug 6, 2026
@fazpu
fazpu enabled auto-merge (squash) August 6, 2026 21:32
@fazpu fazpu closed this Aug 7, 2026
auto-merge was automatically disabled August 7, 2026 05:03

Pull request was closed

@fazpu fazpu reopened this Aug 7, 2026
@fazpu
fazpu enabled auto-merge (squash) August 7, 2026 05:04
@fazpu
fazpu merged commit a6ba50f into main Aug 7, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant