fix: BEAM scorer + P2 export dual-review follow-ups - #228
Merged
Conversation
Apply Codex + Claude Accept-with-changes findings: - P2 export: avoid pathological memory_v1.entities_current / graph_edges_visible_history plans; use base tables + TEMP graph_survivor; set LOCAL statement_timeout so hangs fail into mark_failed. - Official scorer: macro ability mean, incremental report writes, retries on transient network/HTTP, no model/provider body leakage, Kendall τ-b tie fix, larger judge max_tokens, fixture provenance notice. - Ops doc: safer cleanup SQL; record export rewrite as done. Dual reviews: design/reviews/REVIEW_*_beam_official_scorer_and_p2_hang_2026-08-07.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dual review (Claude Fable + Codex Sol) of #226 found Accept-with-changes issues on the official BEAM scorer and a clear P2 hang root cause that still needed a code fix.
Scope
P2 hang (lab-verified)
memory_v1.entities_current/graph_edges_visible_historyplansSET LOCAL statement_timeout = '120s'insidegraph_exportEntity774,RELATES195)Official scorer
Reviews checked in
design/reviews/REVIEW_claude-fable_beam_official_scorer_and_p2_hang_2026-08-07.mddesign/reviews/REVIEW_codex-sol_beam_official_scorer_and_p2_hang_2026-08-07.mdValidation
uv run pytest src/tests/benchmarks/test_beam_official_score.py -q→ 7 passedproject --plane p2with patchedprojection.py→ publishedContributor agreement