fix(locomo): attest durable visible versions - #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make LoCoMo isolation attest durable uploaded versions through the public
documents_live→document_versions_visiblejoin instead of treatingdocuments_live.current_version_idas an upload pointer. Update the binding benchmark contract, operator recovery wording, and focused regression coverage.Problem and important decision
A fresh full-v10 run uploaded a session and checkpointed the returned version, then failed before the next upload. The previous query parsed
documents_live.current_version_idas mandatory. That field is intentionally a readiness pointer: it remains null until structure processing publishes ready content. It is therefore not the authority for durable upload identity.The exact public join now selects
(deployment_id, source_ref, doc_id, version_id)fromdocuments_liveanddocument_versions_visible, with bothdeployment_idanddoc_idin the join predicate. Exact set equality still rejects extra, replaced, tombstoned, or cross-deployment state. No direct database access, RLS, retry loop, or readiness wait is added.Sources inspected
plan/designs/locomo_benchmark_design.mdpre-run isolation contractsrc/rememberstack/spine/migrations/versions/p9_01_0022_memory_v1_query_space.pysemantics ofdocuments_liveanddocument_versions_visiblesrc/rememberstack/spine/document_catalog.pyreadiness publication ofcurrent_version_idValidation and review
git diff --checkpassedLimitations and follow-up
The current partial run is revision-pinned and will not be forced forward. After merge, build the exact merged main image and prepare a new run directory. Prior empty/partial benchmark state is disposable.
Contributor agreement
Signing on behalf of a legal entity (leave blank if accepting individually):