fix: update publishing tag - #1135
Conversation
WalkthroughThe publish workflow’s tag trigger pattern changed to include a turbo- infix. The version extraction step still matches the previous agent-builder- prefix, causing parsing to fail and halting subsequent steps. No other workflow steps were modified. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub Actions
participant Step1 as Extract Version (Regex)
participant Steps as Subsequent Steps
Dev->>GH: Push tag agent-builder-turbo-X.Y.Z-image-A.B.C-main
GH->>Step1: Run publish workflow
Note over Step1: Regex expects "agent-builder-" (no "turbo-")
Step1-->>GH: Extraction fails
GH--X Steps: Skip remaining steps due to failure
Note over GH: Workflow exits before publish
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/publish.yml (2)
33-41: Pin Python version for reproducibility and cache key stability.Without
python-version, runner default may change and break builds/cache.Apply:
- name: Set up Python uses: actions/setup-python@v5 with: - cache: 'poetry' + python-version: '3.11' + cache: 'poetry'
11-11: Sanity check: 10-minute job timeout might be tight for Poetry + build + publish.If recent runs skirt the limit, bump to 20 to reduce flakiness.
- timeout-minutes: 10 + timeout-minutes: 20
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/publish.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: build (3.13)
- GitHub Check: build (3.10)
- GitHub Check: build (3.11)
- GitHub Check: build (3.10)
- GitHub Check: build (3.12)
- GitHub Check: build (3.13)
- GitHub Check: build (3.12)
- GitHub Check: build (3.11)
- GitHub Check: build (3.9)
- GitHub Check: build (3.9)
- GitHub Check: tests (firefox)
- GitHub Check: tests (webkit)
- GitHub Check: tests (chromium)
🔇 Additional comments (2)
.github/workflows/publish.yml (2)
16-25: Support turbo tags in version extraction (keep backward compatibility)Verified — optional
turbo-group captures correctly; use${BASH_REMATCH[2]}for the version.- if [[ "$REF" =~ ^agent-builder-([0-9]+\.[0-9]+\.[0-9]+)-image-([0-9]+\.[0-9]+\.[0-9]+)-main$ ]]; then - echo "version=${BASH_REMATCH[1]}" >> "$GITHUB_OUTPUT" + # Supports agent-builder-turbo-… and legacy agent-builder-… tags + if [[ "$REF" =~ ^agent-builder-(turbo-)?([0-9]+\.[0-9]+\.[0-9]+)-image-([0-9]+\.[0-9]+\.[0-9]+)-main$ ]]; then + echo "version=${BASH_REMATCH[2]}" >> "$GITHUB_OUTPUT" else echo "Unable to parse version from tag: $REF" >&2 exit 1 fi
6-6: Replace regex-like tag pattern with a globFile: .github/workflows/publish.yml (line 6). Dry-run confirms the glob matches intended tags and excludes others — it matched 'agent-builder-turbo-1.2.3-image-4.5.6-main' and did not match 'agent-builder-1.2.3-image-4.5.6-main'.
- - 'agent-builder-turbo-[0-9]+.[0-9]+.[0-9]+-image-[0-9]+.[0-9]+.[0-9]+-main' + - 'agent-builder-turbo-*-image-*-main'
Summary by CodeRabbit