docs(.shared): centralize shell portability guidance - #440
Merged
Conversation
Document read-time conditions for every reference and keep chain and review material out of the common no-chain dispatch path. Enforce the manifest condition through boundary tests. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
Give every agent-composed multi-line recipe one explicit Bash boundary and one shared source for zsh, quoting, and stdin hazards. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Require verification isolation whenever agent-run output needs interpretation and adversarial review guidance for every cross-review caller. Pin both conditions in manifest and dispatch boundary tests. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
Refresh the serialized predecessor while preserving issue 428 shell-portability guidance. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
Escape the example pipeline as GFM table content and make the duplicate guard search for the literal bare-pipe form. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
Collaborator
Author
|
This was written agentically; verify its assertions: Adversarial review receipt
🤖 Co-authored by Codex gpt-5.6-sol. |
Resolve reference-loading conflicts while preserving the shared shell-portability contract and current main assertions. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
7 tasks
Preserve the shared shell-portability boundary while integrating current dispatch-plan and verification coverage behavior. Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
Co-Authored-By: Codex gpt-5.6-sol <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was written agentically; verify its assertions:
Why
Agent-composed multi-line recipes run in the harness shell, which may be zsh, while the existing portability guidance lived only in one review reference and did not cover common Bash-only constructs.
What
Decisions
.shhelpers unchanged because their Bash shebangs are the correct boundary.bash -cboundary only for agent-composed multi-line recipes.Stacked on #436; merge #436 first, then merge its updated base down and retarget this PR to
mainbefore merge.base=origin/feat/issue-427
files=8
total.insertions=96
total.deletions=7
total.lines=103
operational.files=8
operational.insertions=96
operational.deletions=7
operational.lines=103
generated.files=0
generated.insertions=0
generated.deletions=0
generated.lines=0
lockfile.files=0
lockfile.insertions=0
lockfile.deletions=0
lockfile.lines=0
fixture.files=0
fixture.insertions=0
fixture.deletions=0
fixture.lines=0
non_operational.files=0
non_operational.insertions=0
non_operational.deletions=0
non_operational.lines=0
Testing
.agent/logs/20260824T152018Z-test.log.test-agent-preflight.shcache assertions reproduced in.agent/logs/20260824T151752Z-test.log.🤖 Co-authored by Codex gpt-5.6-sol.
Closes #428