docs(parallel-issues): warn that gh api -f/-F promotes reads to POST - #458
Merged
Conversation
A field run hit gh api repos/<owner>/<repo>/issues with a filter and got a 422 from a POST, not the intended GET -- gh api infers POST from any -f/-F unless -X GET is passed explicitly. merge-gate.sh already knew this in code; the REST-routing prose that tells agents to route reads through gh api never said so. Add the warning at both instruction sites (SKILL.md and its references/triage-and-selection.md detail) plus a correct filtered-read example. Co-Authored-By: Claude claude-sonnet-5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
Author
|
This was written agentically; verify its assertions: Adversarial review receipt
🤖 Co-authored by Claude Fable 5 (root orchestrator). |
This was referenced Aug 25, 2026
Merges the 13-PR wave that landed on main (Work-shape verdict, run-dir ledger recipe, wait-bound reprint, and more) into this branch, ahead of PR #458 merge. Auto-merged cleanly at the file level in both files this branch touches (parallel-issues/SKILL.md and references/triage-and-selection.md) -- no conflict markers, both the -X GET REST-routing warning and every main-only addition are present. Re-measured the parallel-issues SKILL.md size ratchet against the merged body: TOKENS rises 19713 -> 19743 (minimum that passes), LINES unchanged at 1133; tests/test-skill-size.sh pinned message updated to match. Co-Authored-By: Claude claude-sonnet-5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was written agentically; verify its assertions:
Why
gh apiinfers its HTTP method from its flags: any-f/-Fparameter promotes the request to POST unless-X GETis explicit. The kit's REST-first guidance told agents to route bulk reads overgh api repos/...without saying so, and a field run's filtered issue read became an attempted issue create in a repository being read. The knowledge lived only in helper code (merge-gate.shpasses-X GET); it now lives at the instruction sites agents actually read.What
parallel-issues/references/triage-and-selection.md: a short paragraph after the REST-routing rule stating the-f/-F→ POST promotion, plus a correct filtered-read example (gh api -X GET "repos/$REPO/issues" -f labels=bug -f state=open).parallel-issues/SKILL.md: one clause on its own REST-routing sentence and a pointer to the example — kept minimal because the file sits at its size ceiling.Decisions
agentkit/references.mdfrom the issue's scope list does not exist; the real index (agentkit/skills/references.md) only points at triage-and-selection.md, so it needed no edit.$REPOrather than a literal<owner>/<repo>placeholder: shellcheck (via the markdown-block gate) misparses the angle brackets as redirection.Diff facts (root,
diff-facts.sh --base origin/main):base=origin/main
files=2
total.insertions=14
total.deletions=3
total.lines=17
operational.files=2
operational.insertions=14
operational.deletions=3
operational.lines=17
generated.files=0
generated.insertions=0
generated.deletions=0
generated.lines=0
lockfile.files=0
lockfile.insertions=0
lockfile.deletions=0
lockfile.lines=0
fixture.files=0
fixture.insertions=0
fixture.deletions=0
fixture.lines=0
non_operational.files=0
non_operational.insertions=0
non_operational.deletions=0
non_operational.lines=0
Testing
agent-run.sh --cmd testALL GREEN (.agent/logs/20260825T133432Z-test.log)-X GET🤖 Co-authored by Claude Sonnet 5 (worker) / Claude Fable 5 (root).
Closes #443