Skip to content

fix(helpers): align documented argv and private output handling - #506

Merged
thewrz merged 8 commits into
mainfrom
feat/issue-497
Aug 27, 2026
Merged

fix(helpers): align documented argv and private output handling#506
thewrz merged 8 commits into
mainfrom
feat/issue-497

Conversation

@thewrz

@thewrz thewrz commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • align helper argv aliases with the documented worktree terminology
  • create private per-worktree output directories automatically
  • exclude ignored .agent/** runtime evidence from pushed-tree dirt checks
  • add regression coverage across each affected helper boundary

Testing

  • tests/run-tests.sh (ALL GREEN; .agent/logs/20260826T230325Z-issue-497-merge-full-retry.log)

Stack

Closes #497

mergetest and others added 4 commits August 26, 2026 15:31
Validate dispatch predictions against the chain base and support auditable same-lead path expansion.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
Accept documented helper flag spellings, create private helper state directories, and ignore excluded agent state during pushed-tree checks.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
Correct reviewed path-validation, prediction, and documentation edge cases.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1c89457-33ac-43f6-a04e-45f8cfd11a46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Codex <noreply@openai.com>
@thewrz

thewrz commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Adversarial review receipt

  • Reviewer: provider=anthropic; model=claude-opus-5; effort=xhigh; mode=cross-provider (reason: User explicitly authorized one Claude adversarial review per draft PR.)
  • Counts: P1=1; P2=3; total=4
  • Reviewed head: d3b5979
  • Diff payload: pr-506-adversarial.diff
  • Confirmed finding: New receipt run directory inherits unsafe ambient mode — verdict=fixed; fix commit SHA(s)=d3b597961e6f50d9e471e2daaa31e3af09296814
  • Confirmed finding: Dirty gate hides tracked agent configuration changes — verdict=fixed; fix commit SHA(s)=d3b597961e6f50d9e471e2daaa31e3af09296814
  • Confirmed finding: Global private umask corrupts checkout and setup modes — verdict=fixed; fix commit SHA(s)=d3b597961e6f50d9e471e2daaa31e3af09296814
  • Confirmed finding: Permission tests require GNU stat on BSD hosts — verdict=fixed; fix commit SHA(s)=d3b597961e6f50d9e471e2daaa31e3af09296814

🤖 Co-authored by Codex orchestrator.

@thewrz

thewrz commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Review ledger

Machine-readable record of every review already performed on this PR.

{
  "version": 1,
  "pr": 506,
  "repo": "wrzonance/agent-kit",
  "reviews": [
    {
      "kind": "adversarial",
      "provider": "anthropic",
      "model": "claude-opus-5",
      "effort": "xhigh",
      "mode": "cross-provider",
      "harness": "codex",
      "head_sha": "d3b597961e6f50d9e471e2daaa31e3af09296814",
      "diff_payload": "pr-506-adversarial.diff",
      "counts": {
        "p1": 1,
        "p2": 3
      },
      "reviewed_at": "2026-08-26T23:22:57Z"
    },
    {
      "kind": "adversarial",
      "provider": "anthropic",
      "head_sha": "51f540e332f0e08c9c1a327796c51b8f7b80bb6d",
      "diff_payload": "fingerprint:f9fadae66dd2606dd4e9ebd4c115fd39bd4b99192f4946ab001b91536d3821e3",
      "reaffirmed_from": {
        "kind": "adversarial",
        "provider": "anthropic",
        "model": "claude-opus-5",
        "effort": "xhigh",
        "mode": "cross-provider",
        "harness": "codex",
        "head_sha": "d3b597961e6f50d9e471e2daaa31e3af09296814",
        "diff_payload": "pr-506-adversarial.diff",
        "counts": {
          "p1": 1,
          "p2": 3
        },
        "reviewed_at": "2026-08-26T23:22:57Z"
      },
      "reaffirmedVerdict": "covered-diff",
      "reviewed_at": "2026-08-27T03:11:10Z"
    }
  ]
}

🤖 Co-authored by codex.

# Conflicts:
#	agentkit/skills/parallel-issues/SKILL.md
#	agentkit/skills/parallel-issues/scripts/write-merge-plan.sh
#	tests/test-write-merge-plan.sh
@thewrz
thewrz changed the base branch from feat/issue-493 to main August 27, 2026 02:59
@thewrz
thewrz marked this pull request as ready for review August 27, 2026 03:11
@thewrz
thewrz merged commit e01493c into main Aug 27, 2026
4 checks passed
@thewrz
thewrz deleted the feat/issue-497 branch August 30, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(helpers): argv matches skill prose, helpers mkdir their outputs, dirty checks ignore .agent/, ship or drop pick-issues.sh

1 participant