Skip to content

fix(review): carry receipt lineage across mechanical heads - #529

Merged
thewrz merged 11 commits into
mainfrom
feat/issue-512
Aug 27, 2026
Merged

fix(review): carry receipt lineage across mechanical heads#529
thewrz merged 11 commits into
mainfrom
feat/issue-512

Conversation

@thewrz

@thewrz thewrz commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

This was written agentically; verify its assertions:

Why

Receipt coverage was pinned only to the reviewed head, so mandated fix commits and merge-down commits made the merge gate reject the same completed review; evidence writers also disagreed on private modes.

Stacked on #523 and also requires #527 — merge both predecessor PRs first.

What

  • Record review, fix, and merge-down heads as a durable receipt lineage.
  • Let the merge gate prove current-head coverage through that lineage and name uncovered commits.
  • Align private evidence modes and extend gate/state regressions.

Decisions

Use append-only lineage evidence rather than rerunning an adversarial review after mechanical head advances.

Stacked on #523 and #527. After both merge, merge updated main down into this branch, push, and run chain-advance.sh --retarget --pr <this-PR> --base main before merge.

The branch includes merge-down bc6631a8569c8a2497fdee41bbf85c63448409d3 from the advanced #527 head.

Diff facts:
base=39418e2c90cadd1807f355b0ef63b9d99e38c9ae
files=11
total.insertions=201
total.deletions=31
total.lines=232
operational.files=11
operational.insertions=201
operational.deletions=31
operational.lines=232
generated.files=0
generated.insertions=0
generated.deletions=0
generated.lines=0
lockfile.files=0
lockfile.insertions=0
lockfile.deletions=0
lockfile.lines=0
fixture.files=0
fixture.insertions=0
fixture.deletions=0
fixture.lines=0
non_operational.files=0
non_operational.insertions=0
non_operational.deletions=0
non_operational.lines=0

Testing

  • Full declared test suite via agent-run.sh --cmd test
  • Root diff review and git diff --check

🤖 Co-authored by Codex gpt-5.6-sol orchestrator; implementation by gpt-5.6-luna high.

Closes #512

mergetest and others added 5 commits August 26, 2026 21:07
Allow a new review receipt after a PR diff changes, while preserving one spend per diff and recording supersession.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
Pass the canonical current diff payload through both review prechecks so superseded skip receipts do not block a genuine material review.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
Record reviewed and subsequent fix or merge-down heads so merge gating can prove lineage without a second adversarial review; secure state artifacts and identify their producer.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 654a30af-ec6b-4097-a769-67775eb0ef89

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Base automatically changed from feat/issue-510 to main August 27, 2026 14:09
mergetest and others added 4 commits August 27, 2026 07:51
Pins the Fable review findings with regression coverage, exact-diff recovery, complete receipt-chain validation, and fresh-shell precheck guards. Declines the materiality rendering finding because the helper matches the canonical consent renderer.

Co-Authored-By: Codex gpt-5.6-luna <noreply@openai.com>
# Conflicts:
#	agentkit/skills/parallel-issues/SKILL.md
#	agentkit/skills/review-remote-pr/scripts/materiality-check.sh
#	agentkit/skills/review-remote-pr/scripts/post-receipt.sh
#	tests/test-adversarial-review-receipt.sh
#	tests/test-post-receipt.sh
@thewrz

thewrz commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Adversarial review receipt

  • Reviewer: provider=anthropic; model=claude-fable-5; effort=xhigh; mode=cross-provider (reason: n/a)
  • Counts: P1=1; P2=5; total=6
  • Reviewed head: f488060
  • Diff payload: wrzonance/agent-kit:529:916fc5cc5643c8d657763652487250be3c26ce81725453e45fb3b0e717d36625
  • Confirmed finding: covered-lineage must record the current tip — verdict=fixed; fix commit SHA(s)=235c2696eab582e0ecc7b412336683813ed2ce56
  • Confirmed finding: merge-down diff coverage must not be short-circuited by lineage stale — verdict=fixed; fix commit SHA(s)=235c2696eab582e0ecc7b412336683813ed2ce56
  • Confirmed finding: failed publish recovery must match the current diff payload — verdict=fixed; fix commit SHA(s)=235c2696eab582e0ecc7b412336683813ed2ce56
  • Confirmed finding: receipt status requires a complete supersession chain — verdict=fixed; fix commit SHA(s)=235c2696eab582e0ecc7b412336683813ed2ce56
  • Confirmed finding: precheck recipes must guard fresh-shell variables — verdict=fixed; fix commit SHA(s)=235c2696eab582e0ecc7b412336683813ed2ce56
  • Confirmed finding: materiality renderer differs from the review payload — verdict=declined; decline rationale=Declined after validation: materiality-check.sh and consent-record.sh share the canonical renderer; the focused materiality suite passes 25 assertions, and the reported alternate helper path is not the one used by this review.

🤖 Co-authored by Codex gpt-5.6-luna.

@thewrz

thewrz commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

This was written agentically; verify its assertions:

Review ledger

Machine-readable record of every review already performed on this PR.

{
  "version": 1,
  "pr": 529,
  "repo": "wrzonance/agent-kit",
  "reviews": [
    {
      "kind": "adversarial",
      "provider": "anthropic",
      "model": "claude-fable-5",
      "effort": "xhigh",
      "mode": "cross-provider",
      "harness": "codex",
      "head_sha": "f488060",
      "diff_payload": "wrzonance/agent-kit:529:916fc5cc5643c8d657763652487250be3c26ce81725453e45fb3b0e717d36625",
      "counts": {
        "p1": 1,
        "p2": 5
      },
      "reviewed_at": "2026-08-27T19:25:27Z"
    },
    {
      "kind": "adversarial",
      "provider": "anthropic",
      "model": "claude-fable-5",
      "effort": "xhigh",
      "mode": "cross-provider",
      "harness": "codex",
      "head_sha": "f488060522f009c815555b3e0f6ed729df71136b",
      "diff_payload": "wrzonance/agent-kit:529:916fc5cc5643c8d657763652487250be3c26ce81725453e45fb3b0e717d36625",
      "counts": {
        "p1": 1,
        "p2": 5
      },
      "reaffirmed_from": "f488060",
      "reaffirmedVerdict": "fix-batch-and-mechanical-merge-down",
      "reviewed_at": "2026-08-27T19:25:27Z"
    }
  ]
}

🤖 Co-authored by Codex gpt-5.6-luna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(pr-to-green): merge gate rejects the receipt after the mandated fix commit or merge-down, and helper evidence modes disagree (0644 vs 0600)

1 participant