Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughDeletes multiple component docs (amp-api, amp-console, amp-trace-observer, amp-eval and its v0.6.x version), adds Observability concept and a Monitor-first-agent tutorial, updates getting-started docs and quick-start to v0.7.0 and adds an Evaluation Extension, and adjusts the website sidebar navigation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
website/docs/getting-started/managed-cluster.mdx (1)
455-455:⚠️ Potential issue | 🟡 MinorIncorrect step reference.
The note references "Phase 1, Step 5" but the Observability Plane installation is actually "Step 4" in Phase 1 (lines 195-223). Step 5 is "Configure Observability Integration."
✏️ Suggested fix
-**Note:** The OpenTelemetry Collector ConfigMap should have been applied in Phase 1, Step 5. If you skipped it, apply it now: +**Note:** The OpenTelemetry Collector ConfigMap should have been applied in Phase 1, Step 4. If you skipped it, apply it now:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@website/docs/getting-started/managed-cluster.mdx` at line 455, Update the note that currently reads "Phase 1, Step 5" to instead reference "Phase 1, Step 4" so it correctly points to the Observability Plane installation (the OpenTelemetry Collector ConfigMap); locate the paragraph containing "OpenTelemetry Collector ConfigMap should have been applied" and replace the step number, ensuring you do not change the surrounding wording or the reference to "Configure Observability Integration."
🧹 Nitpick comments (1)
website/docs/getting-started/self-hosted-cluster.mdx (1)
522-568: Consider adding Evaluation Extension verification.The Verification section doesn't include a specific check for the new Evaluation Extension added in Step 7. For consistency with other extensions, consider adding a verification step:
# 5.5. Check Evaluation Extension (if installed) echo "=== Evaluation Extension Status ===" kubectl get pods -n openchoreo-build-plane | grep -E "amp-evaluation"Alternatively, a general
helm list -n openchoreo-build-planecheck already covers it, so this is optional.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@website/docs/getting-started/self-hosted-cluster.mdx` around lines 522 - 568, Add a Verification step for the Evaluation Extension inside the "Verification" section (near the existing "Check Build Extension" block) that runs against the openchoreo-build-plane namespace and looks for pods matching amp-evaluation (e.g., similar to the existing Build Extension check using kubectl get pods -n openchoreo-build-plane | grep -E "amp-evaluation"); label it consistently (e.g., "Check Evaluation Extension Status") so it mirrors other extension checks and is optional if not installed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@website/docs/concepts/observability.mdx`:
- Line 11: The sentence "Every agent interaction — LLM calls, tool invocations,
MCP requests, retrieval operations, and agent reasoning steps is captured..."
has a subject-verb agreement/punctuation issue; update that sentence (the line
containing "Every agent interaction — LLM calls, tool invocations, MCP requests,
retrieval operations, and agent reasoning steps is captured") to use correct
grammar and punctuation, e.g., change "is captured" to "are captured" or
restructure the clause with proper dashes/commas so it reads "Every agent
interaction — LLM calls, tool invocations, MCP requests, retrieval operations,
and agent reasoning steps — is captured" or "Every agent interaction, such as
LLM calls, tool invocations, MCP requests, retrieval operations, and agent
reasoning steps, is captured" to fix agreement and punctuation.
- Around line 41-43: The "Trace Visibility in AMP Console" heading currently
ends mid-sentence; expand that paragraph under the "Trace Visibility in AMP
Console" section to include concise instructions on how to access the AMP
Console, where traces appear (e.g., Traces or Observability dashboard), brief
steps to filter/search traces, and a link to the relevant tutorial or docs page;
mention the section name "Trace Visibility in AMP Console" so you add a short
example of viewing a single trace and tips for useful filters.
In `@website/docs/getting-started/self-hosted-cluster.mdx`:
- Around line 114-117: The four hardcoded URLs in
website/docs/getting-started/self-hosted-cluster.mdx that point to amp/v0.7.0
(the entries for values-bp.yaml, values-op.yaml, values-cp.yaml, values-dp.yaml)
must be updated to reference an existing tag—either change amp/v0.7.0 to
amp/v0.6.0 or to a valid rc tag such as amp/v0.7.0-rc9 depending on which
release you want to document; update each URL consistently so the links resolve
(values-bp.yaml, values-op.yaml, values-cp.yaml, values-dp.yaml).
In `@website/docs/tutorials/monitor-first-agent.mdx`:
- Around line 39-44: The tutorial uses
AMP_OTEL_ENDPOINT="http://localhost:22893/otel" which conflicts with the Quick
Start's OpenTelemetry Collector port 21893; update the example to match the
Quick Start (use 21893) or make it explicit that the port should match the
user's AMP instance/Quick Start (e.g., keep AMP_OTEL_ENDPOINT but change port to
21893 or add a note referencing the Quick Start port), and ensure the text
around AMP_OTEL_ENDPOINT and the sentence "Replace the endpoint..." clearly
instructs users to use the Quick Start's OTLP HTTP endpoint if different.
---
Outside diff comments:
In `@website/docs/getting-started/managed-cluster.mdx`:
- Line 455: Update the note that currently reads "Phase 1, Step 5" to instead
reference "Phase 1, Step 4" so it correctly points to the Observability Plane
installation (the OpenTelemetry Collector ConfigMap); locate the paragraph
containing "OpenTelemetry Collector ConfigMap should have been applied" and
replace the step number, ensuring you do not change the surrounding wording or
the reference to "Configure Observability Integration."
---
Nitpick comments:
In `@website/docs/getting-started/self-hosted-cluster.mdx`:
- Around line 522-568: Add a Verification step for the Evaluation Extension
inside the "Verification" section (near the existing "Check Build Extension"
block) that runs against the openchoreo-build-plane namespace and looks for pods
matching amp-evaluation (e.g., similar to the existing Build Extension check
using kubectl get pods -n openchoreo-build-plane | grep -E "amp-evaluation");
label it consistently (e.g., "Check Evaluation Extension Status") so it mirrors
other extension checks and is optional if not installed.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
website/docs/components/amp-api.mdxwebsite/docs/components/amp-console.mdxwebsite/docs/components/amp-trace-observer.mdxwebsite/docs/concepts/observability.mdxwebsite/docs/getting-started/managed-cluster.mdxwebsite/docs/getting-started/quick-start.mdxwebsite/docs/getting-started/self-hosted-cluster.mdxwebsite/docs/tutorials/monitor-first-agent.mdxwebsite/sidebars.ts
💤 Files with no reviewable changes (3)
- website/docs/components/amp-console.mdx
- website/docs/components/amp-trace-observer.mdx
- website/docs/components/amp-api.mdx
| | **Build Plane** | [values-bp.yaml](https://raw.githubusercontent.com/wso2/agent-manager/amp/v0.7.0/deployments/single-cluster/values-bp.yaml) | | ||
| | **Observability Plane** | [values-op.yaml](https://raw.githubusercontent.com/wso2/agent-manager/amp/v0.7.0/deployments/single-cluster/values-op.yaml) | | ||
| | **Control Plane** | [values-cp.yaml](https://raw.githubusercontent.com/wso2/agent-manager/amp/v0.7.0/deployments/single-cluster/values-cp.yaml) | | ||
| | **Data Plane** | [values-dp.yaml](https://raw.githubusercontent.com/wso2/agent-manager/amp/v0.7.0/deployments/single-cluster/values-dp.yaml) | |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Test URL accessibility for the v0.7.0 references
echo "=== Testing URL accessibility ==="
# Test one of the URLs mentioned in the documentation
test_url="https://raw.githubusercontent.com/wso2/agent-manager/amp/v0.7.0/deployments/single-cluster/values-bp.yaml"
echo "Testing: $test_url"
curl -sI "$test_url" | head -n 1
# Also test if a typical v0.7.0 tag (without amp/) exists
echo ""
echo "Testing alternative tag format (without 'amp' prefix):"
test_url2="https://raw.githubusercontent.com/wso2/agent-manager/v0.7.0/deployments/single-cluster/values-bp.yaml"
echo "Testing: $test_url2"
curl -sI "$test_url2" | head -n 1
# Check what branches/tags are available
echo ""
echo "=== Checking available refs in repository ==="
curl -s "https://api.github.com/repos/wso2/agent-manager/git/refs/tags" | head -c 500Repository: wso2/agent-manager
Length of output: 951
🏁 Script executed:
#!/bin/bash
# Get all available tags to find the correct version reference
echo "=== All available tags in wso2/agent-manager ==="
curl -s "https://api.github.com/repos/wso2/agent-manager/git/refs/tags" | jq -r '.[].ref' | sortRepository: wso2/agent-manager
Length of output: 1322
The documentation references the non-existent v0.7.0 tag—only release candidates exist.
The URLs point to amp/v0.7.0, which does not exist in the repository. The latest release is amp/v0.6.0, with only release candidates available for v0.7.0 (amp/v0.7.0-rc1 through amp/v0.7.0-rc9). Either update the documentation to reference a released version or create and tag the v0.7.0 release before merging.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@website/docs/getting-started/self-hosted-cluster.mdx` around lines 114 - 117,
The four hardcoded URLs in website/docs/getting-started/self-hosted-cluster.mdx
that point to amp/v0.7.0 (the entries for values-bp.yaml, values-op.yaml,
values-cp.yaml, values-dp.yaml) must be updated to reference an existing
tag—either change amp/v0.7.0 to amp/v0.6.0 or to a valid rc tag such as
amp/v0.7.0-rc9 depending on which release you want to document; update each URL
consistently so the links resolve (values-bp.yaml, values-op.yaml,
values-cp.yaml, values-dp.yaml).
| @@ -0,0 +1,86 @@ | |||
| --- | |||
There was a problem hiding this comment.
We are not releasing the SDK. Do we need this tutorial?
There was a problem hiding this comment.
This tutorial is an observability one, I renamed it
Purpose
Update structure of documentation and add updates for v0.7 (quickstart/self-hosted/managed)
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit