Update observability and setup to work for oc 0.16#519
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughUpdated OpenChoreo service endpoints and port-forwarding, made the OpenChoreo setup script use a cross‑platform sed approach with verification, improved OpenSearch error logging, and migrated OpenSearch queries and tests to use .keyword fields consistently. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AnoshanJ
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployments/scripts/port-forward.sh`:
- Around line 70-71: The kubectl port-forward call for the OpenChoreo API
("kubectl port-forward svc/openchoreo-api -n openchoreo-control-plane
8195:8080") is missing a trailing ampersand and runs in the foreground, blocking
subsequent status checks and wait logic; update that invocation to run in the
background (append &), mirroring the other port-forward invocations so the
status block and final wait/trap behavior function correctly.
In `@deployments/scripts/setup-openchoreo.sh`:
- Line 369: The sed invocation that rewrites the JWKS URL (the line that edits
api-platform-operator-local-config.yaml replacing
http://amp-api.wso2-amp.svc.cluster.local:9000/auth/external/jwks.json with
http://host.k3d.internal:9000/auth/external/jwks.json) uses BSD-only `sed -i ''`
and is brittle if the source line changes; make it portable and fail-fast by
using a POSIX-friendly in-place approach (e.g., create a temporary/backup file
with sed -i.bak or use perl -pi) and after the edit verify the replacement
actually occurred (check that the new JWKS URL is present and the old one is
absent), and if verification fails exit with a non-zero status and a clear error
message so the setup script stops rather than silently leaving the wrong JWKS
URI.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e8cafca3-4262-4d14-af95-6b291b7f38fd
📒 Files selected for processing (8)
agent-manager-service/.env.exampledeployments/docker-compose.ymldeployments/scripts/port-forward.shdeployments/scripts/setup-openchoreo.shtraces-observer-service/opensearch/client.gotraces-observer-service/opensearch/composite_queries_test.gotraces-observer-service/opensearch/queries.gotraces-observer-service/opensearch/queries_test.go
hanzjk
reviewed
Mar 10, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployments/scripts/port-forward.sh`:
- Around line 70-73: The status block in the port-forward script is missing an
entry for the new OpenChoreo Api forward (kubectl port-forward
svc/openchoreo-api mapping 8195:8080 added in
deployments/scripts/port-forward.sh); update the status section that lists
active forwards to include a line for "OpenChoreo Api — localhost:8195 ->
svc/openchoreo-api:8080" (place it alongside the other status entries in the
status block after the other forwards) so users can see the new port-forward in
the script's status output.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 38c651d7-6c4b-4201-ac5d-95466fd1d216
📒 Files selected for processing (2)
deployments/scripts/port-forward.shdeployments/scripts/setup-openchoreo.sh
Comment on lines
+70
to
+73
| echo "Forwarding OpenChoreo Api (8195)..." | ||
| kubectl port-forward svc/openchoreo-api -n openchoreo-control-plane 8195:8080 & | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Missing status entry for the new port-forward.
The OpenChoreo Api port-forward is added but the status block (lines 76-83) doesn't include it. All other port-forwards have their status listed for user reference.
Proposed fix to add the status line
Add the following line in the status block (e.g., after line 83):
echo " OpenBao (Secrets): http://localhost:8200"
+echo " OpenChoreo Api: http://localhost:8195"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@deployments/scripts/port-forward.sh` around lines 70 - 73, The status block
in the port-forward script is missing an entry for the new OpenChoreo Api
forward (kubectl port-forward svc/openchoreo-api mapping 8195:8080 added in
deployments/scripts/port-forward.sh); update the status section that lists
active forwards to include a line for "OpenChoreo Api — localhost:8195 ->
svc/openchoreo-api:8080" (place it alongside the other status entries in the
status block after the other forwards) so users can see the new port-forward in
the script's status output.
Contributor
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Contributor
Author
There was a problem hiding this comment.
Seems already merged. Yes we can add this in another PR then.
hanzjk
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Changes to Observability to work with OC 0.16
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit
Chores
Improvements