Remove helm hooks from evaluation extension workflow templates

[nadheesh]

Summary

• Remove helm.sh/hook annotations from ClusterWorkflowTemplate and Workflow CR in the evaluation extension chart so they are created as regular Helm resources
• Add amp-evaluation-extension to uninstall.sh cleanup and add EVALUATION_NS variable

Fixes #569

Why

Commits 6cab0e8/8a893cb1 converted these resources to Helm hooks (post-install,post-upgrade). In dev mode (VERSION=0.0.0-dev), the chart doesn't exist in the OCI registry so helm install fails silently — neither the Workflow CR nor ClusterWorkflowTemplate get created, causing all monitor creation to fail with Workflow not found.

These hooks were unnecessary — the evaluation extension always installs after the OpenChoreo build plane which already registers the Argo Workflows CRDs.

Test plan

• Run ./install.sh inside amp-quick-start container
• Verify kubectl get workflows.openchoreo.dev -A shows monitor-evaluation-workflow
• Verify kubectl get clusterworkflowtemplate shows amp-monitor-evaluation
• Create a monitor from the UI and confirm it succeeds without Workflow not found error
• Run ./uninstall.sh and confirm amp-evaluation-extension is uninstalled cleanly

Summary by CodeRabbit

• Chores
  • Removed Helm hook annotations from workflow templates; resources now deploy as standard manifests
  • Added uninstall support for the Evaluation Extension during package removal

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b5efcf20-0f4d-43ea-830b-0de76159ee56

📥 Commits

Reviewing files that changed from the base of the PR and between 5c9ce49 and 2185a62.

📒 Files selected for processing (3)

• deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/cluster-workflow-monitor-evaluation.yaml
• deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/workflow-monitor-evaluation.yaml
• deployments/quick-start/uninstall.sh

💤 Files with no reviewable changes (2)

• deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/workflow-monitor-evaluation.yaml
• deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/cluster-workflow-monitor-evaluation.yaml

---

📝 Walkthrough

Walkthrough

This change removes Helm hook annotations from two workflow template manifests and adds uninstall cleanup logic for the evaluation extension in the quick-start script, ensuring consistent state across reinstalls.

Changes

Cohort / File(s)	Summary
Workflow Template Helm Hooks deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/cluster-workflow-monitor-evaluation.yaml, deployments/helm-charts/wso2-amp-evaluation-extension/templates/workflow-templates/workflow-monitor-evaluation.yaml	Removed Helm hook annotations (hook, hook-weight, hook-delete-policy) to convert resources from hook-managed to standard manifests.
Quick-start Uninstall Script deployments/quick-start/uninstall.sh	Added evaluation extension namespace variable and uninstall logic to clean up the amp-evaluation-extension Helm release during uninstall.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A cleanup spell we weave today,
Hooks removed, workflows stay,
Uninstall scripts now complete,
No ghost resources left to greet! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main changes: removing Helm hook annotations from evaluation extension workflow templates.
Description check	✅ Passed	The description provides a clear summary of changes, rationale, and test plan, though it deviates from the template structure with minimal coverage of standard sections.
Linked Issues check	✅ Passed	The PR changes directly address issue #569: removing Helm hooks ensures workflow resources are created reliably, and adding uninstall support prevents cluster inconsistency.
Out of Scope Changes check	✅ Passed	All changes are within scope: Helm hook removal from workflow templates and uninstall.sh cleanup align with fixing issue #569.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}