Skip to content

Add SECRET_MANAGER_API_URL and baseURL configuration for Secret Manager#688

Merged
hanzjk merged 1 commit intowso2:mainfrom
hanzjk:secret-seup
Apr 9, 2026
Merged

Add SECRET_MANAGER_API_URL and baseURL configuration for Secret Manager#688
hanzjk merged 1 commit intowso2:mainfrom
hanzjk:secret-seup

Conversation

@hanzjk
Copy link
Copy Markdown
Contributor

@hanzjk hanzjk commented Apr 9, 2026

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter �N/A� plus brief explanation of why there�s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type �Sent� when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type �N/A� and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Summary by CodeRabbit

  • Chores
    • Added configuration option for secret manager base URL in deployment settings, enabling operators to specify custom secret manager endpoints.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 19dfb303-5385-4df3-8f5b-35a59af5da58

📥 Commits

Reviewing files that changed from the base of the PR and between c226408 and 17c1d3a.

📒 Files selected for processing (2)
  • deployments/helm-charts/wso2-agent-manager/templates/agent-manager-service/configmap.yaml
  • deployments/helm-charts/wso2-agent-manager/values.yaml

📝 Walkthrough

Walkthrough

The pull request adds a new SECRET_MANAGER_API_URL environment variable to the Helm chart's ConfigMap, with the value sourced from a new baseURL configuration field in the values file under the secret manager settings.

Changes

Cohort / File(s) Summary
Secret Manager Configuration
deployments/helm-charts/wso2-agent-manager/templates/agent-manager-service/configmap.yaml, deployments/helm-charts/wso2-agent-manager/values.yaml
Added new SECRET_MANAGER_API_URL environment variable to ConfigMap template, sourced from agentManagerService.config.secretManager.baseURL configuration field in values (defaults to empty string).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A whisper of URLs in templates spring,
Configuration values dance and sing,
BaseURL blooms beneath the sea,
Of secrets managed, wild and free!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely template boilerplate with no actual content filled in for any required sections (Purpose, Goals, Approach, etc.). Fill in the template sections with specific details about the purpose, goals, approach, and impact of this configuration change, including any related issues, testing, and documentation.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: adding SECRET_MANAGER_API_URL environment variable and baseURL configuration for the Secret Manager.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanzjk hanzjk merged commit fd68eca into wso2:main Apr 9, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants