Prevent workflow env value update for agent kind#894
Conversation
📝 WalkthroughWalkthroughThis PR adds error handling for non- ChangesComponent Deployment Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agent-manager-service/clients/openchoreosvc/client/components.go`:
- Line 1312: The UpdateComponentWithResponse calls are inconsistent:
UpdateComponentDeploymentConfig was updated to propagate updateResp.JSON400 into
the returned UpdateComponentResp but the other update wrappers (the functions
that call UpdateComponentWithResponse such as the other Update... methods
referencing UpdateComponentWithResponse and returning UpdateComponentResp) still
omit JSON400; update those functions to include JSON400: updateResp.JSON400 in
their returned UpdateComponentResp so all update operations consistently surface
HTTP 400 validation details from the generated client (reference symbols:
UpdateComponentWithResponse, UpdateComponentResp, JSON400,
UpdateComponentDeploymentConfig).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b4f5c2cc-ad38-4a13-a02b-48f55398f728
📒 Files selected for processing (1)
agent-manager-service/clients/openchoreosvc/client/components.go
Prevent workflow env value update for agent kind
Purpose
When redeploying the agent (created from kind), it tries to update the env variables in the workflow. But workflows aren't available for this agent type.
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit
Release Notes