Remove unnecessary configs#2700
Conversation
📝 WalkthroughWalkthroughConfiguration documentation, JWT startup validation, encryption-key handling, and listener initialization were updated. Environment variables are documented as interpolation inputs, JWT secrets are validated across authentication modes, encryption uses the consolidated setting, and TLS/listener checks occur before startup. ChangesPlatform configuration and startup
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@platform-api/internal/server/server.go`:
- Around line 832-834: Update the warning message in the logger call so the
concatenated literals in the Plain-HTTP listener warning include a separating
space or punctuation after “(http.enabled=true)”. Preserve the existing message
content and logging behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a699ce52-c530-42bd-bb52-0114ae8a6e39
📒 Files selected for processing (8)
platform-api/README.mdplatform-api/config/config.goplatform-api/config/config.tomlplatform-api/internal/repository/subscription_repository.goplatform-api/internal/server/server.goportals/ai-workspace/configs/config-platform-api-template.tomlportals/ai-workspace/configs/config-platform-api.tomlportals/developer-portal/docs/administer/manage-organizations.md
💤 Files with no reviewable changes (1)
- portals/ai-workspace/configs/config-platform-api.toml
This pull request makes several improvements and clarifications to the Platform API configuration files and related documentation, focusing on security, environment variable usage, and listener/TLS configuration. It also updates code comments for accuracy and consistency with the configuration changes.
Resolves: #2682
Configuration and Security Improvements:
api-platform.envinstead of the previouskeys.envfor environment variables, clarifying where secrets should be stored. [1] [2] [3]audienceconfiguration for IDP authentication is now clearly documented, with instructions on how to use and override it.Listener and TLS Configuration:
tlssection is now explicitly included and described in the main configuration files, ensuring users know how to set up certificates. [1] [2]Code and Comment Consistency:
APIP_CP_ENCRYPTION_KEYis now described asEncryptionKey, and error messages are clarified). [1] [2]Minor Cleanups: