Skip to content

docs: home the login plan under docs/plans and record the auth decision - #31

Merged
kanushka merged 1 commit into
feature/loginfrom
docs/login-plan-and-adr
Aug 5, 2026
Merged

docs: home the login plan under docs/plans and record the auth decision#31
kanushka merged 1 commit into
feature/loginfrom
docs/login-plan-and-adr

Conversation

@kanushka

@kanushka kanushka commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to the #17 stack (part of #17).

  • Moves docs/superpowers/plans/2026-08-05-login-first-slice.md to docs/plans/login-first-slice.md, matching the existing docs/plans/ naming convention, and removes the docs/superpowers/ directory. The plan's dead reference to a never-committed spec file now points at issue wso2 login first slice: browser PKCE and inline client credentials against Asgardeo and IS #17, and the agent-tooling header is dropped.
  • Indexes the plan in docs/README.md alongside the two existing plans.
  • Adds ADR 0004: Shell-Brokered Authentication — the durable decisions the login slice made: shell-only credential custody, public client + PKCE, keychain-only sessions with fail-closed refusal, per-kind token sources behind the broker seam, and verification of issued tokens (a deployment that cannot narrow is refused, never granted broader access).

https://claude.ai/code/session_01RojiAgW9hi3b9f9G6ZXBVp

@kanushka
kanushka requested a review from hevayo as a code owner August 5, 2026 05:02
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 02a5258b-f277-4c3f-99ba-180024fa9ab4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kanushka
kanushka merged commit 2cbf028 into feature/login Aug 5, 2026
5 checks passed
@kanushka
kanushka deleted the docs/login-plan-and-adr branch August 5, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant