-
Notifications
You must be signed in to change notification settings - Fork 4
Executor - configurable notifier ID #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor - configurable notifier ID #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces configurable notifier ID support for the executor component, allowing notifications to be sent to specific notification channels rather than just the default one.
- Adds a configurable notifier ID field to the Executor configuration
- Refactors NotificationManager to support sending messages to specific notifiers by ID
- Consolidates message building logic by moving it from NotificationManager to payload builders
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Executor.java | Adds notifier ID configuration and updates notification calls to use specific notifier |
| NotificationManager.java | Refactors to support notifier-specific messaging and removes duplicate message building logic |
| TeamsPayload.java | Adds message() builder method to consolidate Teams message creation |
| SlackPayload.java | Adds message() builder method to consolidate Slack message creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/main/java/dev/vml/es/acm/core/notification/NotificationManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/notification/teams/TeamsPayload.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/notification/slack/SlackPayload.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fixes #198