Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the OSGi-service-based SlingLogInterceptor (which registered Logback appenders via Sling's AppenderTracker as OSGi services) with LogbackLogInterceptor, which directly attaches/detaches Logback appenders to individual loggers using reflection. The LogbackAppenderFactory is refactored from exposing low-level lifecycle methods to providing a higher-level attach/detach API, and a new isAvailable() check is moved into the factory.
Changes:
SlingLogInterceptoris removed and replaced byLogbackLogInterceptor, which directly attaches the Logback appender to individual loggers via reflection instead of relying on Sling'sAppenderTrackerOSGi mechanism.LogbackAppenderFactoryis refactored: constants madeprivate, OSGi-related lifecycle methods removed, and new higher-levelattach/detach/isAvailablemethods added.LogInterceptorManagerhas its class-level Javadoc removed (which referenced the now-deletedSlingLogInterceptor).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
SlingLogInterceptor.java |
Deleted entirely; replaced by the new LogbackLogInterceptor approach |
LogbackLogInterceptor.java |
New OSGi component that directly attaches/detaches Logback appenders per-logger via LogbackAppenderFactory |
LogbackAppenderFactory.java |
Refactored: constants privatized; new isAvailable, attach, detach methods; per-logger attach/detach helpers added |
LogInterceptorManager.java |
Javadoc removed (contained stale reference to SlingLogInterceptor) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackAppenderFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackLogInterceptor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackAppenderFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackAppenderFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackAppenderFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackLogInterceptor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
core/src/main/java/dev/vml/es/acm/core/code/log/LogbackAppenderFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
No description provided.