Skip to content

solves #337: Add an offline mode to be able to read the symbolic name of a jar file without accessing the instance#343

Merged
krystian-panek-vmltech merged 1 commit into
wttech:mainfrom
royteeuwen:feature/add-offline-mode
May 5, 2026
Merged

Conversation

@royteeuwen
Copy link
Copy Markdown
Contributor

No description provided.

…c name of a jar file without accessing the instance
@royteeuwen
Copy link
Copy Markdown
Contributor Author

@krystian-panek-vmltech is this project / repository still alive and maintained? Not getting any feedback on any of my PR's / issues :/

@krystian-panek-vmltech
Copy link
Copy Markdown
Contributor

Yes it's alive but maintaining this costs sth 🙂 in the meantime I have implemented instance in place upgrade. if you wish the next one will be this one. Sure. I just forgot to respond. I have a lot of open source projets to maintain sry 🙂

@royteeuwen
Copy link
Copy Markdown
Contributor Author

No problem, I can definitely understand seeing as I do have a few of my own open-source repositories :D. Are you open to introducing a contributor role so that you aren't the sole committer, to make it more sustainable :)?

@krystian-panek-vmltech
Copy link
Copy Markdown
Contributor

Hey @royteeuwen, thanks for the contribution! The use case is totally valid - comparing local bundles with remote ones to avoid unnecessary reinstalls makes a lot of sense for performance.

I'll merge this as-is to unblock you, but I'm planning a small refactor right after:

The --offline flag changes the semantics of bundle read quite significantly - it returns a different data structure (BundleManifest vs OSGiBundle) and doesn't actually "read" from an instance. This can be confusing for users and breaks the implicit API contract.

I'm thinking of extracting this into a dedicated command like:

aem osgi bundle manifest --file bundle.jar

This way:

  • Clear intent - "manifest" = local JAR metadata
  • Consistent output contract per command
  • Easier to document and discover
  • --file flag keeps its original meaning in bundle read

The functionality stays the same, just reorganized. Let me know if you have any concerns!

@krystian-panek-vmltech krystian-panek-vmltech merged commit 70a2bd9 into wttech:main May 5, 2026
@royteeuwen
Copy link
Copy Markdown
Contributor Author

@krystian-panek-vmltech completely fine :) go ahead and change to the semantics you find logical, i'll start using it afterwards ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants