Skip to content

Sidepanel focus follows active report#226

Merged
wiiitek merged 6 commits intomasterfrom
sidepanel-focus-follows-active-report
Feb 23, 2018
Merged

Sidepanel focus follows active report#226
wiiitek merged 6 commits intomasterfrom
sidepanel-focus-follows-active-report

Conversation

@michaldziubek
Copy link
Copy Markdown
Contributor

@michaldziubek michaldziubek commented Feb 19, 2018

Description

The side panel focus follows now the currently opened report while navigating between them using [ ] keyboard shortcuts.
In addition, the unused mCustomScrollbar plugin was removed from source code.

Motivation and Context

There is functionality to navigate between test's urls using [ ] keys on keyboard.
Hovewer the sidepanel navigation did not follow the active report - the user had to scroll the Side panel manually in order to find the currently opened report.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Copy link
Copy Markdown

@mateuszluczak mateuszluczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Copy Markdown

@szymon-owczarzak szymon-owczarzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@wiiitek wiiitek merged commit a01e7c9 into master Feb 23, 2018
@wiiitek wiiitek deleted the sidepanel-focus-follows-active-report branch February 23, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants