Skip to content

Glyphicons changed to Font Awesome#233

Merged
wiiitek merged 16 commits intomasterfrom
fontawesome
Mar 6, 2018
Merged

Glyphicons changed to Font Awesome#233
wiiitek merged 16 commits intomasterfrom
fontawesome

Conversation

@edworczak
Copy link
Copy Markdown
Contributor

Description

All Glyphicons are changed to Font Awesome.

Motivation and Context

Icons from Font Awesome are more flexible than Glyphicons, prettier and there are more of them.


I hereby agree to the terms of the AET Contributor License Agreement.


<!--
Comments modal
-->
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the old popup to add a comment that was no longer needed.

Copy link
Copy Markdown

@szymon-owczarzak szymon-owczarzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please make sure that there is no more junk left from old icons in css files.

var titleElement = $('.filter-list-title p '),
iconApply = $('.filter-list-title .glyphicon-chevron-down'),
iconCancel = $('.filter-list-title .glyphicon-remove');
iconApply = $('.filter-list-title .apply-filters'),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@wiiitek wiiitek merged commit d1c955d into master Mar 6, 2018
@wiiitek wiiitek deleted the fontawesome branch March 6, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants