Switch off the default require.js timeout#239
Merged
Conversation
wiiitek
approved these changes
Apr 17, 2018
Contributor
|
See also wttech/aet-cookbook#17 |
mateuszluczak
approved these changes
Apr 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is switching off the default require.js timeout, to prevent report app from not loading while on slow network.
Motivation and Context
Currently, in most cases, the report app is not loading on slow networks due to timeout caused by require.js (Uncaught Error: Load timeout for modules: angularAMD,lodash,angular-bootstrap,angular-ui-router,jquery,bootstrap,scroller,angular). This change is switching off the default timeout, to prevent it from happening.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.