Skip to content

Js error table fix#252

Merged
wiiitek merged 3 commits intomasterfrom
js-error-table-fix
Apr 27, 2018
Merged

Js error table fix#252
wiiitek merged 3 commits intomasterfrom
js-error-table-fix

Conversation

@jakublamprecht
Copy link
Copy Markdown
Contributor

Now proper information about no JS Errors is displayed instead of empty table

Description

Changed conditions so that appropriate message is shown to the user depending on whether there were JS Errors or not

Motivation and Context

Displaying empty table can be confusing to users

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@wiiitek wiiitek merged commit e2c7725 into master Apr 27, 2018
@wiiitek wiiitek deleted the js-error-table-fix branch April 27, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants