Prepare for grid#264
Merged
malaskowski merged 7 commits intomasterfrom Jun 27, 2018
Merged
Conversation
wiiitek
force-pushed
the
prepare-for-grid
branch
from
659ffb5 to
72a4d90
Compare
malaskowski
approved these changes
Jun 18, 2018
Contributor
malaskowski
left a comment
malaskowski
left a comment
There was a problem hiding this comment.
How about renaming test parameter to browser?
I know the name webDriverId is more appropriate here from the technical perspective, but when we make changes in the AET suite DSL, it should be more user-friendly.
malaskowski
approved these changes
Jun 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let's introduce a way to use different web driver than default.
This PR introduces changes for test to spoecify preferred browser ID.
This way we could have more than one WebDriver factories active. Usage example:
Motivation and Context
It enables us to work gradually on new web drivers (selenium grid).
We are still maintaining current way of usng Firefox 38.6 ESR
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.