Skip to content

Guice removed completely#267

Merged
malaskowski merged 1 commit intomasterfrom
guice-removed
Jun 29, 2018
Merged

Guice removed completely#267
malaskowski merged 1 commit intomasterfrom
guice-removed

Conversation

@wiiitek
Copy link
Copy Markdown
Contributor

@wiiitek wiiitek commented Jun 29, 2018

Let'd remove dependencies on Google Guice injection framework.

Description

The pull request #265 removed Guice usage in worker module. Now we are able to remove it from poms and we no longer need the guice for AET bundles. Some dependencies are needed for bobcat for functional tests module.

Motivation and Context

It is enough for AET to use OSGi dependeny injection: components, services, references. For that we are using deprecated Felix SCR annotations and SCR Maven plugin, but that is something we can address in future.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

@malaskowski malaskowski merged commit a109ebe into master Jun 29, 2018
@malaskowski malaskowski deleted the guice-removed branch June 29, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants