Skip to content

Update osgi annotations in proxy#311

Merged
plutasnyy merged 3 commits intofeature/upgrade-osgi-annotationsfrom
update-osgi-annotation-proxy
Aug 10, 2018
Merged

Update osgi annotations in proxy#311
plutasnyy merged 3 commits intofeature/upgrade-osgi-annotationsfrom
update-osgi-annotation-proxy

Conversation

@PiteroS678
Copy link
Copy Markdown
Contributor

Description

I updated osgi annotations in proxy

Motivation and Context

Before, annotations was marked as deprecated

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
</dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    <dependency>
      <groupId>org.apache.felix</groupId>
      <artifactId>org.apache.felix.scr.annotations</artifactId>
    </dependency>

Is probably no longer needed here?

<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
</dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also

    <dependency>
      <groupId>org.apache.sling</groupId>
      <artifactId>org.apache.sling.commons.osgi</artifactId>
    </dependency>

can be safely removed now.

@plutasnyy plutasnyy merged commit c0b277b into feature/upgrade-osgi-annotations Aug 10, 2018
@plutasnyy plutasnyy deleted the update-osgi-annotation-proxy branch August 10, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants