Remove jmsEndpointConfig information from communication settings endpoint#354
Merged
tkaik merged 5 commits intowttech:masterfrom Nov 16, 2018
Conversation
malaskowski
suggested changes
Sep 13, 2018
Contributor
malaskowski
left a comment
malaskowski
left a comment
There was a problem hiding this comment.
@sp2mbn thanks for contribution.
Could you please update the CHANGELOG.md according to AET contribution rules ?
|
|
||
| private final String reportDomain; | ||
|
|
||
| public CommunicationSettings(JmsEndpointConfig jmsEndpointConfig, String reportDomain) { |
Contributor
There was a problem hiding this comment.
It looks that JmsEndpointConfig is no longer used anywhere. It should be removed.
| String reportDomain = reportConfigurationManager.getReportDomain(); | ||
|
|
||
| if (COMMUNICATION_SETTINGS_PARAM.equals(configType)) { | ||
| JmsEndpointConfig jmsEndpointConfig = jmsConnection.getEndpointConfig(); |
Contributor
There was a problem hiding this comment.
Also, method JmsConnection.getEndpointConfig() is not used elsewhere, please remove it (from the interface and implementation).
Removed JmsConnection.getEndpointConfig() method Udpated Changelog
…nication-settings
malaskowski
approved these changes
Sep 17, 2018
…nication-settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed jmsEndpointConfig information from communication settings endpoint
Description
Motivation and Context
Fixed #352
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.