Skip to content

Upgrade codesniffer to 3.2.0#430

Merged
malaskowski merged 13 commits intowttech:masterfrom
wblachowski:feature/upgrade-html-codesniffer
Nov 21, 2018
Merged

Upgrade codesniffer to 3.2.0#430
malaskowski merged 13 commits intowttech:masterfrom
wblachowski:feature/upgrade-html-codesniffer

Conversation

@wblachowski
Copy link
Copy Markdown
Contributor

@wblachowski wblachowski commented Nov 14, 2018

I upgraded AccessSniff to version 3.2.0 (issue #420)

Description

Htmlcs js has been updated to AccessSniff 3.2.0. All custom code has been incorporated into new version (the custom changes are listed in comment at the top of the file).


I hereby agree to the terms of the AET Contributor License Agreement.

@tkaik
Copy link
Copy Markdown
Contributor

tkaik commented Nov 14, 2018

Good job! Please update Changelog with this PR

* changed scope of variable to window
* added HTMLCS.getMessagesJSON()
*/
(function (root, factory) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not look like minified file.
But I see that previous versions was not minified also (and was named ...min.js).

@malaskowski malaskowski added the QA Required Requires manual tests, possible regression or impact on existing features. label Nov 19, 2018
@GrzegorzBednarski
Copy link
Copy Markdown

Tested & accepted

@malaskowski malaskowski merged commit 0e47daf into wttech:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Required Requires manual tests, possible regression or impact on existing features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants