Skip to content

Popup window unification#462

Merged
tkaik merged 8 commits intowttech:masterfrom
wblachowski:bugfix/popup-window-unification
Jul 8, 2019
Merged

Popup window unification#462
tkaik merged 8 commits intowttech:masterfrom
wblachowski:bugfix/popup-window-unification

Conversation

@wblachowski
Copy link
Copy Markdown
Contributor

@wblachowski wblachowski commented Dec 27, 2018

I unified styles of popup windows as described in #367

Description

Changes:

  • New suite history modal with bootstrap styling
  • "X" icon added to note editor modal
  • Change wording of keyboard shortcuts modal ("use" -> "press")

Motivation and Context

Closes #367

Screenshots

New modals:
historymodal
editormodal
shortcutsmodal

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@tkaik tkaik added the QA Required Requires manual tests, possible regression or impact on existing features. label Jul 3, 2019
Copy link
Copy Markdown
Contributor

@tkaik tkaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tkaik tkaik merged commit 791ff47 into wttech:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA Required Requires manual tests, possible regression or impact on existing features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

report popup window unification

4 participants