Fix WebAPI issues#469
Merged
tkaik merged 14 commits intowttech:masterfrom Feb 20, 2019
Merged
Conversation
added 11 commits
January 18, 2019 13:54
Asia95
reviewed
Jan 22, 2019
| - [PR-404](https://github.com/Cognifide/aet/pull/404) Added missing tooltip for conditional tests | ||
| - [PR-408](https://github.com/Cognifide/aet/pull/408) Advanced Screen Comparision button layout fix | ||
| - [PR-410](https://github.com/Cognifide/aet/pull/410) Notification that displays when exclude-elements are not found on page now shows what specific elements were not found([#372](https://github.com/Cognifide/aet/issues/372)) | ||
| - [PR-469](https://github.com/Cognifide/aet/pull/469) Fix WebAPI issues([#425](https://github.com/Cognifide/aet/issues/425)) |
plutasnyy
reviewed
Jan 25, 2019
| } else if (suiteName != null) { | ||
| paramsValuesMessage = String.format("suite name: %s", suiteName); | ||
| if (suiteVersion != null) { | ||
| paramsValuesMessage = String.format("%s, version: %s", paramsValuesMessage, suiteVersion); |
Contributor
There was a problem hiding this comment.
Is everything ok with formatting?
Contributor
Author
There was a problem hiding this comment.
Looks fine to me, these are nested if statements. It's OK according to Google Style
plutasnyy
approved these changes
Feb 1, 2019
|
Tested and accepted. QA Covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed some inconsistencies in WebAPI responses and provided more meaningful 404 messages.
Closes #425
Description
Issues addressed:
http://aet-vagrant:8181/api/artifact?company=company&project=project&id=99999999
500404http://aet-vagrant:8181/api/artifact?company=company&project=project&id=99999999
400404http://aet-vagrant:8181/api/metadata?company=company&project=project&suite=no_existing_suite
400404http://aet-vagrant:8181/api/metadata?company=company&project=project&suite=test-suite&version=999
400404http://aet-vagrant:8181/configs/locks
Motivation and Context
Closes #425
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.