Conversation
Add unit tests for fuzz option Update existing code to fit the new fuzz option
|
Testing on a working AET instance not done yet. |
|
Documentation not done yet. |
|
Testing on a working AET instance - done, works fine. |
|
Documentation done |
|
We could add some slightly different images (lie those generated by AEM renditions engines) to our integration tests with example of how to use |
|
#507 (comment) |
|
#507 (comment) I don't think they are really necessary. And also I don't know what is the role of integration tests currently. I have looked into sample files for integration tests - they are taken from the real-life use cases, right? |
|
I like this feature very much! Problems with images were really really annoying. I think a bit about users - if a test is marked as a fail user doesn't know if it was because of threshold or fuzzy. I also think that using it together is not the best way so I wouldn't change anything. |
|
#507 (comment) Changelog updated So, what exactly am I required to do to have this merged? I would love to use this as soon as possible. :D |
plutasnyy
left a comment
There was a problem hiding this comment.
From my side you have approval. Good luck ;)
Description
Introduce an option to match colors that are close to the target color in a grayscale space when comparing pixels with the LayoutComparator.
The comparison can now run in two modes:
In other words - a naive implementation of https://imagemagick.org/script/command-line-options.php#fuzz
Motivation and Context
This option allows to filter out image rendering issues like AEM image rendition differences not visible to the human eye.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.