Skip to content

Comments

Styling | Form and Widget more menu style improved#269

Merged
szymon-owczarzak merged 2 commits intomasterfrom
feature/form-styling-improvements
Aug 6, 2020
Merged

Styling | Form and Widget more menu style improved#269
szymon-owczarzak merged 2 commits intomasterfrom
feature/form-styling-improvements

Conversation

@marcin-witaszek-wttech
Copy link
Collaborator

@marcin-witaszek-wttech marcin-witaszek-wttech commented Aug 3, 2020

Description

Few styling changes:

  • removed focus outline from widget More Menu
  • moved User Login form submit button outside of fieldset to adjust spacing between text fields and button and maintain consistency across all app forms
  • changed color of focused text field to improve user experience, because currently label and bottom border is invisible when the field is focused - focus state color is the same as form dialog background

Motivation and Context

These styling changes improve visual look & feel of dialog forms and admin user experience during board settings updating.

Screenshots (if appropriate)

More Menu before:
Screenshot 2020-08-03 at 11 14 49

More Menu after:
Screenshot 2020-08-03 at 11 07 00

User Login form before:
Screenshot 2020-08-03 at 11 15 36

User Login form after:
Screenshot 2020-08-03 at 11 07 51

Upgrade notes (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Automated functional tests have been added or modified to cover my changes (if applicable)
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Cogboard Contributor License Agreement.

…ext inputs; adjusted spacing in UserLogin form
@marcin-witaszek-wttech marcin-witaszek-wttech added the enhancement New feature or request label Aug 3, 2020
Copy link
Contributor

@szymon-owczarzak szymon-owczarzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach screens with highlighted changes

@marcin-witaszek-wttech
Copy link
Collaborator Author

@szymon-owczarzak Sure, I edited the comment.

@szymon-owczarzak szymon-owczarzak merged commit b6fc3bb into master Aug 6, 2020
@szymon-owczarzak szymon-owczarzak changed the title Form and widget more menu styling improvements Styling | Form and Widget more menu style improved Sep 21, 2020
@GrzegorzBednarski GrzegorzBednarski deleted the feature/form-styling-improvements branch October 16, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants