fix: orphan subgraphs not shown as active on the header - #3086
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughWorkspace subgraph fields were revised across the proto contract, generated bindings, control-plane namespace assembly, Studio lookup components, and association tests. Federated graphs now carry subgraph target IDs, while namespace-level subgraph objects provide display and routing data. ChangesWorkspace subgraph migration
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (72.34%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
===========================================
- Coverage 71.12% 43.30% -27.83%
===========================================
Files 335 1070 +735
Lines 49350 139680 +90330
Branches 6038 7328 +1290
===========================================
+ Hits 35100 60486 +25386
- Misses 14224 77334 +63110
- Partials 26 1860 +1834
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@proto/wg/cosmo/platform/v1/platform.proto`:
- Around line 2850-2857: Update the WorkspaceFederatedGraph message to reserve
field number 5 for the former subgraphs field, then assign repeated string
subgraphs a new unused field number. Preserve all existing field numbers and
names otherwise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a56c8966-2cd2-425b-9159-0ef430b2824b
⛔ Files ignored due to path filters (1)
connect-go/gen/proto/wg/cosmo/platform/v1/platform.pb.gois excluded by!**/*.pb.go,!**/gen/**
📒 Files selected for processing (6)
connect/src/wg/cosmo/platform/v1/platform_pb.tscontrolplane/src/core/services/WorkspaceService.tsproto/wg/cosmo/platform/v1/platform.protostudio/src/components/dashboard/graph-command-group.tsxstudio/src/components/dashboard/workspace-command-wrapper.tsxstudio/src/components/dashboard/workspace-selector.tsx
…h-doesnt-render-correctly
…h-doesnt-render-correctly
Summary by CodeRabbit
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.