ERROR Cannot read properties of undefined (reading 'forEach')

[dongnaebi]

Describe the bug

I followed the guide to try out wxt, but when I added a content script, dev threw an error as soon as it ran.

 ERROR  Cannot read properties of undefined (reading 'forEach') 

I couldn't figure out what the problem was or how to continue. Did I miss something?

To Reproduce

wxt-demo.zip

1. Install dependencies: pnpm i
2. Start dev mode: pnpm dev

Expected behavior

Screenshots

Environment

  System:
    OS: Windows 11 10.0.22621
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11600KF @ 3.90GHz
    Memory: 4.14 GB / 15.84 GB
  Binaries:
    Node: 18.19.0 - ~\.nvmd\versions\18.19.0\node.EXE
    npm: 10.2.3 - ~\.nvmd\versions\18.19.0\npm.CMD
    pnpm: 8.12.0 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Edge: Chromium (120.0.2210.144)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    wxt: ^0.14.0 => 0.14.5 

[nnx0r]

Perhaps the docs require an update, but TS prompts me in your demo that you need to provide matches property inside of your example-ui.content.ts

// e.g.
export default defineContentScript({
  matches: ['https://*/*', 'http://*/*'],
  main(ctx) {
    // ...
  }
});

[aklinker1]

@dvlden is correct. Perhaps we should add validation, TS isn't enough if misconfigured or if you're using JS.

I don't think vite or nuxt include validation outside TS though...

[aklinker1]

Did the error message not print a stack trace? That should have pointed you to matches being required.

If not, this should be the first change before doing any sort of validation

[aklinker1]

Interesting, wxt build passes, but just doesn't assign a value to matches in the manifest. That should be fixed as well. Probably need validation for that to work.

[aklinker1]

It does output a stacktrace, but the bundled code doesn't make it very clear exactly what is wrong. It does mention matches, and there's enough context for me to recognize what the issue is, but probably not to everyone else. I'll add some basic validation.

[aklinker1]

Validation messages added in https://github.com/wxt-dev/wxt/releases/tag/v0.14.6

[dongnaebi]

Sorry for not replying sooner with more information. The speed of this fix is amazing!

I think we should also update the docs, since the hello world example is very important for beginners.

https://wxt.dev/guide/content-script-ui.html