Merged
Conversation
grzuy
force-pushed
the
update-phoenix_live_view-0-13
branch
from
1a70b0a to
cdf9c31
Compare
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
grzuy
force-pushed
the
update-phoenix_live_view-0-13
branch
4 times, most recently
from
d16a049 to
c402bd0
Compare
eldano
approved these changes
Sep 9, 2021
Contributor
eldano
left a comment
eldano
left a comment
There was a problem hiding this comment.
Small comment to remove a warning, other than that LGTM
eldano
reviewed
Sep 9, 2021
Contributor
Author
|
Making it draft so we wait to have feature test coverage for history before merging this in. |
Contributor
Author
|
Updated this branch to be built on top of |
grzuy
force-pushed
the
update-phoenix_live_view-0-13
branch
from
aa6c764 to
c00db7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.